openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi into lp:purchase-wkfl

To: mp+196681@xxxxxxxxxxxxxxxxxx
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Thu, 06 Feb 2014 12:03:35 -0000
In-reply-to: <20131205163336.15121.25227.launchpad@ackee.canonical.com>
Reply-to: mp+196681@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review + test

Hi,

This LGTM. I just have the little remark I already made: 

 * Adding a LTA on a product should add a supplierinfo entry as well.

A part from that, LGTM. I don't want to block it for that. Just to let you know.

Regards,
-- 
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi/+merge/196681
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

References

[Merge] lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi into lp:purchase-wkfl
From: Nicolas Bessi - Camptocamp, 2013-12-05