openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing

Hi, Daniel, thank you very much for the contribution.

What worries me with this new source is that you are using feedparser library. This library is not detected on module install, and it will only fail if you select this source, causing the background process to fail. The alternative is to put this library as dependency, but maybe is to force user to install another library if they are not going to use this source.

What everybody thinks about this?

Regards.
-- 
https://code.launchpad.net/~oerp.ca/account-financial-tools/add-bank-of-canada-rss/+merge/204377
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.