openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #03690
Re: [Merge] lp:~echeverrifm/oemedical/7.0_oemedical_emr into lp:oemedical
Review: Needs Fixing
Hi, Federico, please check some conventions to apply:
- Use from . import xxx in __init__.py.
- Use orm.Model instead of osv.Model.
- Don't instantiate model classes.
- You can safely remove security/oemedical_security.xml, because it's empty. In previous comments, we were talking about ir.model.access.csv.
Regards.
--
https://code.launchpad.net/~echeverrifm/oemedical/7.0_oemedical_emr/+merge/204149
Your team OEmedical Commiter is subscribed to branch lp:oemedical.
Follow ups
References