← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~echeverrifm/oemedical/7.0_oemedical_emr into lp:oemedical

 

> Hi, Federico, please check some conventions to apply:
> 
> - Use from . import xxx in __init__.py.
> - Use orm.Model instead of osv.Model.
> - Don't instantiate model classes.
> - You can safely remove security/oemedical_security.xml, because it's empty.
> In previous comments, we were talking about ir.model.access.csv.
> 
> Regards.

Hello, Pedro
I did

- Use from . import models
- Use orm.Model in two models that it was using osv.Model
- Removed security/oemedical_security.xml
- Don't instantiate model classes 

Regards


-- 
https://code.launchpad.net/~echeverrifm/oemedical/7.0_oemedical_emr/+merge/204149
Your team OEmedical Commiter is subscribed to branch lp:oemedical.


References