openerp-community-reviewer team mailing list archive

[Mario Arias <the.clone.master@xxxxxxxxx>]

Review: Needs Fixing code and test

Hi,

There is a problem with create method on partner.py

If vals['name'] is really False then line 93 will skip the replacement of 'name' with 'lastname', and will finally fail on _write_name when tries to evaluate field_value.isspace()   (line 56)

Correct line 93 should be:
    if 'name' in vals:
-- 
https://code.launchpad.net/~nemry/partner-contact-management/7.0-partner-firstname/+merge/202713
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.