openerp-community-reviewer team mailing list archive

["Olivier Laurent \(Acsone\)" <olivier.laurent@xxxxxxxxx>]

Hi Sandy, just to clarify ...

I understand perfectly your position but the Jonathan's MP is ***NOT*** a response to the Maxime's blueprint. In fact, it is exactly the opposite, Maxime wrote the blueprint consequently to the Jonathan's MP.

Thus, the MP is just an improvement of the **current** addon, not a global solution covering all the wishes enumerated in the blueprint.

For the record, the real cause of the yaml crash is not precisely the existence of the required lastname field. It's the edi_import method itself that unconditionally ignores ***ALL*** function fields instead of ignoring such fields only if their _fnct_inv method is not specified, i.e.
            # skip function/related fields
            if isinstance(field, fields.function):
                _logger.warning("Unexpected function field value ...

against:
            # skip function/related fields
            if isinstance(field, fields.function) and not field._fnct_inv:
                _logger.warning("Unexpected function field value ...

Regards

Olivier

-- 
https://code.launchpad.net/~nemry/partner-contact-management/7.0-partner-firstname/+merge/202713
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.