openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #03950
Re: [Merge] lp:~agilebg/openerp-mrp-reports/adding_mrp_webkit into lp:openerp-mrp-reports
Review: Needs Fixing
Ciao Nico
you should remove mrp_webkit/.DS_Store
and run a PEP8 validator
When importing Python modules from the same addon, use explicit relative import rather than absolute import, example in __init__.py, do not use:
import sale
But
from . import sale
line 552: osv is not used
--
https://code.launchpad.net/~agilebg/openerp-mrp-reports/adding_mrp_webkit/+merge/207471
Your team OpenERP Community Reviewer/Maintainer is requested to review the proposed merge of lp:~agilebg/openerp-mrp-reports/adding_mrp_webkit into lp:openerp-mrp-reports.
Follow ups
References