openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review

Hi, Roberto, thank you very much for your contribution. I see these little things to fix:

- You must enclose in different 'if' some conditions to avoid possible False:

if(data_id.find('input').get(0) != undefined) {
    if(data_id.find('input').get(0).type == 'checkbox' {
        if (data_id.find('input').get(0).checked){
            text = _t("True");
        }
        else {
            text = _t("False");
        } 
    }
.
.
.
or am I not understanding correctly the code?

- Include updated translatation template file.

Regards.
-- 
https://code.launchpad.net/~onnis-roberto/web-addons/6.1/+merge/207662
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons/6.1.