openerp-community-reviewer team mailing list archive

[Lorenzo Battistini - Agile BG <lorenzo.battistini@xxxxxxxxxxx>]

Review: Needs Information

Hello Alexandre,

line 223: if vals['type'] == 'service', should we run _compute_procurement_vals anyway?

lines 585 and 597: as 'product_procurement_type_dropshipping' depends on 'product_procurement_type', why do the write and create methods call the '_compute_procurement_vals' method, already called by 'product_procurement_type'?

Thanks!
-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/209018
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.