openerp-community-reviewer team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review + no tests

Hi,


Regarding Lorenzo's comments:

 * L223 : IMO think that's not necessary
 * L585 : I agree with Lorenzo's opinion here, you should remove the write and create override in the product_procurement_type_dropshipping module. Already made in the product_procurement_type one.

Thanks !
-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/209018
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.