openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting.

Requested reviews:
  Product Core Editors (product-core-editors)
Related bugs:
  Bug #1293524 in Product - Kitting Management: "sale_bom_split: _create_picking_and_procurements ignores picking_id"
  https://bugs.launchpad.net/product-kitting/+bug/1293524

For more details, see:
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293524-afe/+merge/211311

[FIX] sale_bom_split: don't ignore picking_id in _create_pickings_and_procurements
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293524-afe/+merge/211311
Your team Product Core Editors is requested to review the proposed merge of lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting.

=== modified file 'sale_bom_split/sale.py'
--- sale_bom_split/sale.py	2012-07-24 12:27:35 +0000
+++ sale_bom_split/sale.py	2014-03-17 13:22:02 +0000
@@ -103,8 +103,7 @@
         # if we have at least one line which have to be split
         # we prepare the picking so we'll be able to bind it
         # to the move lines
-        picking_id = False
-        if bom_order_lines:
+        if bom_order_lines and not picking_id:
             picking_id = picking_obj.create(
                 cr, uid, self._prepare_order_picking(cr, uid, order, context=context))