← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting

To: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Mon, 17 Mar 2014 14:08:29 -0000
In-reply-to: <20140317132323.29092.95317.launchpad@ackee.canonical.com>
Reply-to: mp+211311@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review

LGTM.

I prefer do "from openerp.osv import orm" and then "class xxx(orm.Model)" to be more recognisable and avoid name collisions (very strange), but it's also good this way.

Regards.
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293524-afe/+merge/211311
Your team Product Core Editors is subscribed to branch lp:product-kitting.

References

[Merge] lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting
From: Alexandre Fayolle - camptocamp, 2014-03-17