← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis

To: mp+211354@xxxxxxxxxxxxxxxxxx
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Mon, 17 Mar 2014 16:59:34 -0000
In-reply-to: <20140317161329.32488.84970.launchpad@ackee.canonical.com>
Reply-to: mp+211354@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information code review

Why do you need to re-read product record? You can make:

product = obj.product_id

Or there is something I'm missing?

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.

References

[Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis
From: Yannick Vaucher @ Camptocamp, 2014-03-17