← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~factorlibre/sale-wkfl/sale-wkfl-7-partnerrisk-partnerinsurance into lp:sale-wkfl

To: "Alberto Garcia \(Factor Libre\)" <alberto.garcia@xxxxxxxxxxxxxxx>
From: "Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>
Date: Mon, 17 Mar 2014 17:13:32 -0000
In-reply-to: <20140304093224.25669.60089.launchpad@ackee.canonical.com>
Reply-to: mp+209204@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Hello Alberto,

Please adapt the code to community standards:

osv.osv -> orm.Model
PEP8
replacement of mx.Datetime by datetime

ll.912 + 963 + 1114 ..

You can remove the class calls.

Cheers,
-- 
https://code.launchpad.net/~factorlibre/sale-wkfl/sale-wkfl-7-partnerrisk-partnerinsurance/+merge/209204
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.

References

[Merge] lp:~factorlibre/sale-wkfl/sale-wkfl-7-partnerrisk-partnerinsurance into lp:sale-wkfl
From: Alberto Garcia (Factor Libre), 2014-03-04