openerp-community-reviewer team mailing list archive

[Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>]

Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons.

Requested reviews:
  Raphaël Valyi - http://www.akretion.com (rvalyi)
  Leonardo Pistone - camptocamp (lpistone): code review
  Lionel Sausin - Numérigraphe (lionel-sausin)
  Pedro Manuel Baeza (pedro.baeza): code review
  Stefan Rijnhart (Therp) (stefan-therp)
  Guewen Baconnier @ Camptocamp (gbaconnier-c2c)
  Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test
  Holger Brunn (Therp) (hbrunn): code review
Related bugs:
  Bug #1079548 in OpenERP Community Backports (Addons): "Message field(char) too short to allow long messages"
  https://bugs.launchpad.net/ocb-addons/+bug/1079548

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488

This fixes a bug where the MRP scheduler fails when messages are too long to be stored in the database (particularly if the locale strings are verbose).
The length constraint is removed altogether as proposed by Guewen Baconnier.

This was approved already but I'm resubmitting because the migration team confirms they WILL truncate the data if we allow larger texts than trunk[1].
So it's trivial only because it's a message log.
I'll leave it up to you to decide among consenting adults as humorously suggested by Raphael.


[1] Complete reply from the migration team:
"""
If you have used 'custom' text fields, then migration process will not check the size of the data.

But if you have increased the size of OpenERP 'standard' fields by patching in the source version code, then migration process will truncate the data to the original shorter size (according to standard code of target version).

However, if your patch can be bundled as a separate custom module, you have the option to send the module to OpenERP so that your changes are considered. In that case, data will not be truncated. However this is a separate service; you may discuss this with your OpenERP account manager or the sales team for more info.
"""

-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.

=== modified file 'procurement/procurement.py'
--- procurement/procurement.py	2013-11-12 15:17:47 +0000
+++ procurement/procurement.py	2014-03-18 11:02:25 +0000
@@ -104,7 +104,7 @@
             readonly=True, required=True, help="If you encode manually a Procurement, you probably want to use" \
             " a make to order method."),
         'note': fields.text('Note'),
-        'message': fields.char('Latest error', size=124, help="Exception occurred while computing procurement orders."),
+        'message': fields.char('Latest error', help="Exception occurred while computing procurement orders."),
         'state': fields.selection([
             ('draft','Draft'),
             ('cancel','Cancelled'),