openerp-community-reviewer team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Approve

Let's hope the change gets adopted in upstream 8.0. At that point, the truncation will only happen when reverting back from OCB 7.0 to OpenERP 7.0. At least in this particular case the impact of the truncation will be nil.

The custom module approach does not work for people who dp "--upgrade all" occasionally (such as OCB users), as the inherited module gets upgraded first, thereby resetting the column width and truncating the data.

If this change does not get adopted in OpenERP 8.0 but will be ported to OCB 8.0, this will cause truncation when upgrading with OPW and interestingly, also with OpenUpgrade. The latter can be prevented by merging in OCB 8.0 addons before running the upgrade. Maybe OPW-users should ask if the same can be done for their migrations.

In all cases, this change is still an improvement even if a migration causes a mild regression for existing records.



-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.