← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

To: mp+211338@xxxxxxxxxxxxxxxxxx
From: Daniel Reis <dgreis@xxxxxxx>
Date: Fri, 21 Mar 2014 10:26:54 -0000
In-reply-to: <20140320231221.30870.65435.launchpad@ackee.canonical.com>
Reply-to: mp+211338@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Great work!

Nitpicks:

L103: could you add the .pot file?
L254-256: the body header text would be best as a single translatable string
L262: s/"Passkey used"/_("Passkey used")
-- 
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.

References

[Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools
From: Sylvain LE GAL (GRAP), 2014-03-20