openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Approve code review

Thanks

Notes (but I won't block the MP for that):

You don't need to do 

    176	+ if context is None:
    177	+     context = {}

When the context is not accessed within the method.

You should prefer self.pool['product.customer.code'] over self.pool.get('product.customer.code') because it the model is missing for some reason, it will fail directly with a KeyError rather than some lines below with a more obscure error (AttributeError: 'NoneType' object has no attribute 'browse')
-- 
https://code.launchpad.net/~agilebg/sale-wkfl/adding_product_customer_code_sale_7/+merge/202468
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.