openerp-community-reviewer team mailing list archive

[Romain Deheele - Camptocamp <romain.deheele@xxxxxxxxxxxxxx>]

Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/sale-wkfl/7.0-fix_1295706-rde into lp:sale-wkfl.

Requested reviews:
  Sale Core Editors (sale-core-editors)
Related bugs:
  Bug #1295706 in Sales - Workflow and Organization: "sale_dropshipping : _create_picking_and_procurements fires picking_id"
  https://bugs.launchpad.net/sale-wkfl/+bug/1295706

For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_1295706-rde/+merge/212175

Hi,

It fixes https://bugs.launchpad.net/sale-wkfl/+bug/1295706
It avoids losing picking_id information and generating more pickings than expected.

Romain
-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_1295706-rde/+merge/212175
Your team Sale Core Editors is requested to review the proposed merge of lp:~camptocamp/sale-wkfl/7.0-fix_1295706-rde into lp:sale-wkfl.

=== modified file 'sale_dropshipping/sale.py'
--- sale_dropshipping/sale.py	2014-03-05 16:28:48 +0000
+++ sale_dropshipping/sale.py	2014-03-21 15:02:23 +0000
@@ -137,7 +137,7 @@
         self._create_procurements_direct_mto(cr, uid, order, dropship_lines,
                                              context=context)
         res = super(sale_order, self)._create_pickings_and_procurements(
-            cr, uid, order, normal_lines, None, context)
+            cr, uid, order, normal_lines, picking_id, context)
         return res
 
     def action_button_confirm(self, cr, uid, ids, context=None):