openerp-community-reviewer team mailing list archive

[Lionel Sausin - Numérigraphe <ls@xxxxxxxxxxxxxxxx>]

Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/ocb-web/7.0-hide-oe_view_only into lp:ocb-web.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1156898 in OpenERP Community Backports (Web): "Hide fields in a form in edit-mode as it is possible for view-mode"
  https://bugs.launchpad.net/ocb-web/+bug/1156898

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_view_only/+merge/212957

This patch written by Daniel Hammerschmidt makes the style "oe_view_only" hide contents in "edit mode", in a way similar to "oe_edit_only" hiding them in "view only" mode.
It is not a bugfix but an small improvement, but even though I'm new to the web client code this looks pretty harmless.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_view_only/+merge/212957
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~numerigraphe-team/ocb-web/7.0-hide-oe_view_only into lp:ocb-web.

=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css	2014-02-13 14:57:55 +0000
+++ addons/web/static/src/css/base.css	2014-03-26 22:06:44 +0000
@@ -2116,7 +2116,8 @@
 .openerp .oe_form_invisible {
   display: none !important;
 }
-.openerp .oe_form_readonly .oe_edit_only, .openerp .oe_form_readonly .oe_form_field:empty {
+.openerp .oe_form_readonly .oe_edit_only, .openerp .oe_form_readonly .oe_form_field:empty,
+.openerp .oe_form_editable .oe_view_only {
   display: none !important;
 }
 .openerp .oe_form_readonly .oe_form .oe_form_field_date {