openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Approve

> Hello,
> actually, the goal is, on the contrary, to have all products set to False
> after install. Only a very small subset of products are to be considered for
> the hours block.

That is our use case, not necessarily the same for everybody.

> Setting all products to True would be the most "iso-prod", given that the
> behaviour after upgrade would be identical to the current one, but unchecking
> all the not-for-hours-block products would be a PITA for users.
That's wrong. The behavior would not be identical. Identical behavior would be to have all products flagged, isn't it?

> 
> Hope this clarifies why the checkbox works that way (and why it's not set to
> True by default).

Totally agree on the logic and default value, my point was only on migration of existing users:
Say I'm using this module. Today, all my products are considered for the hours block. I update the module. Nothing work anymore because no products are flagged. Could be misinterpreted as a bug of the module. On the other hand, if we added a migration script only for existing users, the transition would be smoother, it would continue to work exactly the same for existing users, but they would have the possibility to unflag the products and new products would not be considered by default.

> 
> Regards,
> Matthieu


Anyway, even if IMO would be better to use a migration for that, maybe it does not worth the work needed for that, so that's ok for me.

Thanks
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management.