openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

To: Alex Comba - Agile BG <alex.comba@xxxxxxxxxxx>
From: Lorenzo Battistini - Agile BG <lorenzo.battistini@xxxxxxxxxxx>
Date: Mon, 07 Apr 2014 07:33:13 -0000
In-reply-to: <20140402150223.4527.78579.launchpad@ackee.canonical.com>
Reply-to: mp+213867@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Thanks to openerp-conventions
https://github.com/nbessi/openerp-conventions
I see
delivery_optional_invoice_line/__openerp__.py:43:5: O600 Warning unknown Manifest key ('active')

Apart from this, LGTM
-- 
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries.

References

[Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries
From: Alex Comba - Agile BG, 2014-04-02