openerp-community-reviewer team mailing list archive

[Alexis de Lattre <alexis@xxxxxxxxxx>]

Alexis de Lattre has proposed merging lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls into lp:account-financial-report.

Requested reviews:
  Account Report Core Editors (account-report-core-editor)
Related bugs:
  Bug #1274194 in Account - Financial Report: "Wrong balance formula in trial balance xls when using date filter"
  https://bugs.launchpad.net/account-financial-report/+bug/1274194

For more details, see:
https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063

Fix for bug 1274194 : in the XLS version of the Trial balance, the forumula of the "Balance" column was wrong when "Filter by date" was used ! So the numbers were wrong in the report... it's critical bug :)
-- 
https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063
Your team Account Report Core Editors is requested to review the proposed merge of lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls into lp:account-financial-report.

=== modified file 'account_financial_report_webkit_xls/report/trial_balance_xls.py'
--- account_financial_report_webkit_xls/report/trial_balance_xls.py	2013-10-31 18:01:41 +0000
+++ account_financial_report_webkit_xls/report/trial_balance_xls.py	2014-04-24 14:35:31 +0000
@@ -218,9 +218,9 @@
                 ('account', account_span, 0, 'text', current_account.name),
             ]
             if _p.comparison_mode == 'no_comparison':
-                
-                debit_cell = rowcol_to_cell(row_pos, 3)                
-                credit_cell = rowcol_to_cell(row_pos, 4)
+
+                debit_cell = rowcol_to_cell(row_pos, 4)
+                credit_cell = rowcol_to_cell(row_pos, 5)
                 bal_formula = debit_cell + '-' + credit_cell
                 
                 if _p.initial_balance_mode: