openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp:department-mgmt

To: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Thu, 24 Apr 2014 17:29:54 -0000
In-reply-to: <20140424150039.18074.72884.launchpad@ackee.canonical.com>
Reply-to: mp+217068@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

Hi, Joël,

The MP you have done seems good, but I see a little problem: this modification can give the user a false impression that the department is selected by task, and when they try to change it, they get frustrated, because it's readonly.

I advice to change field label to 'Project department' to avoid this confussion.

Regards.
-- 
https://code.launchpad.net/~camptocamp/department-mgmt/add-dep-on-project-task-jge/+merge/217068
Your team Department Core Editors is subscribed to branch lp:department-mgmt.

References

[Merge] lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into lp:department-mgmt
From: Joël Grand-Guillaume, 2014-04-24