openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #06619
Re: [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Review: Needs Fixing code review, no tests
Hi Lionel,
Thanks for the contrib ! A few remarks concerning community guideline:
* L32 : use from . import purchase
* L95 : use full path instead : from openerp.osv import orm
* L114 : use let a print, remove it please
Otherwise, LGTM,
Regards,
Joël
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
References