openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn into lp:ocb-server

To: "Cedric Le Brouster\(OpenFire\)" <cedric.lebrouster@xxxxxxxxxxx>
From: Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>
Date: Fri, 13 Jun 2014 07:57:20 -0000
In-reply-to: <20140522145120.12578.26684.launchpad@ackee.canonical.com>
Reply-to: mp+220666@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, sometest without being able to exercise that code

LGTM : the connection must be closed. 

But

I cannot find by reading the code a case where this branch is executed (i.e. a logical path in which we get len(self._connections) >= self._maxconn so I'm wondering if we are not improving dead code here. 

Do you have a scenario at hand?
-- 
https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn/+merge/220666
Your team OpenERP Community Backports is subscribed to branch lp:ocb-server.

References

[Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn into lp:ocb-server
From: Cedric Le Brouster(OpenFire), 2014-05-22