← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde into lp:account-financial-tools

 

Review: Needs Fixing code review

Hi, Chaffique. Thanks for your contribution. I think it's the first you make. Let's hope this one is the first of a lot.

In the MP, you put two modules, the one you refer in the MP description, and account_tax_update. Please remove this second one from the MP.

About account_journal_sale_refund_link, you have to follow some conventions set to assure quality. Here is a link to the document used to build theses conventions:

https://pad.odoo.com/p/community-review

Regards.
-- 
https://code.launchpad.net/~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde/+merge/223022
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.


References