← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account into lp:partner-contact-management

 

Thanks for the review Ana

My point about title_bank_account is that most of Models have standard `name` and `description` fields.
I agree having a second field description is quiet useful to add note on the object when you open it.

However as res.partner.bank is already a bank account, naming a field xxx_bank_account seams also redundant. Thus I think it is badly named.

Still, module description doesn't match what the module does. This is more about adding fields for informations than allowing to manage multiple bank accounts. Or am I missing something?
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.


References