openerp-community-reviewer team mailing list archive

[Romain Deheele - Camptocamp <romain.deheele@xxxxxxxxxxxxxx>]

Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529

Hello,

stock_cancel addon introduces a button named "re-open" that allows to re-open a done or canceled picking.
It seems that in practical it's safer to restrict this feature to warehouse managers.
What do you think about it?

Feel free to share your opinion,

Romain
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529
Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows.

=== modified file 'stock_cancel/stock_view.xml'
--- stock_cancel/stock_view.xml	2013-06-05 14:38:18 +0000
+++ stock_cancel/stock_view.xml	2014-06-18 09:46:16 +0000
@@ -8,7 +8,8 @@
             <field name="inherit_id" ref="stock.view_picking_out_form"/>
             <field name="arch" type="xml">
                 <button name="%(stock.act_stock_return_picking)d" position="after">
-                    <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"/>
+                    <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"
+                            groups="stock.group_stock_manager"/>
                 </button>
             </field>
 		</record>
@@ -19,7 +20,8 @@
             <field name="inherit_id" ref="stock.view_picking_in_form"/>
             <field name="arch" type="xml">
                 <button name="%(stock.act_stock_return_picking)d" position="after">
-                    <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"/>
+                    <button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"
+                            groups="stock.group_stock_manager"/>
                 </button>
             </field>
 		</record>
@@ -30,7 +32,8 @@
 			<field name="inherit_id" ref="stock.view_picking_form"/>
 			<field name="arch" type="xml">
 				<button name="%(stock.action_stock_invoice_onshipping)d" position="after">
-					<button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"/>
+					<button name="action_revert_done" string="Reopen" states="done,cancel" type="object" icon="gtk-cancel" confirm="Are you sure you want to reopen this stock picking?"
+                                                groups="stock.group_stock_manager"/>
 				</button>
 			</field>
 		</record>