openerp-community-reviewer team mailing list archive

[Alexandre Fayolle - camptocamp <alexandre.fayolle@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

If people are willing to maintain this, then I'm not opposed to merging in server-env-tools. 

2 points, though, to gain my approval:

* the various size constraints seem overzealous to me (esp. server URL and domain which are obviously too short for no good reason)

* there are no automated tests, and for functionality such as this one, this is definitely needed. 


-- 
https://code.launchpad.net/~gdgellatly/server-env-tools/base-synchro-7.0/+merge/200127
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.