openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Approve code review, no test

l.330 you need to be sure context is a dict before using get

l.536 you can use dict setter

dict['split_key'] = [(3, id) for id
                     in vals.get(split_key, False)[0][2]]

Thaught this wasn't the target here.

I'll approve already as we want those change to enable travis on github when migrated
-- 
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-flake8/+merge/225456
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.