openerp-community team mailing list archive

["Olivier Dony \(OpenERP\)" <odo@xxxxxxxxxxx>]

Review: Needs Fixing

Hi,

The bzr_set script is kind of deprecated for a few reasons:
- it does not setup shared bzr repositories, hence is not a good way to initialize a development environment (check out of new branches will be needlessly slow)
- for production environments it might be workable, but it fetches the extra-addons branches that are deprecated in favor of OpenERP Apps, therefore not very useful

We mention in the 6.1 release note that a new script can be used for setting up a developer environment:
   http://bit.ly/openerp61RN#heading=h.seriyncfihuy

Nevertheless, thanks for helping maintain bzr_set.py.

How about making your patch a little bit more generic and already compatible with the about-to-be-released 6.1 version? You could probably just test something like version < '6.1' to set the correct path for all future versions.
This could also be written more concisely:
  bzr_links = { 'addons/*': version < '6.1' and 'server/bin/addons' or 'server/openerp/addons/' }
(or with the Python 2.5 if/else boolean operators)

Thanks!
-- 
https://code.launchpad.net/~openerp-community/openerp/skitzotek_trunk_symlinks/+merge/93115
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp/skitzotek_trunk_symlinks.