openerp-community team mailing list archive

[Niels Huylebroeck <niels@xxxxxxxxxxxxx>]

Niels Huylebroeck has proposed merging lp:~openerp-community/openobject-addons/fix-1105067-account_payment_reference_type into lp:openobject-addons/7.0.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #1105067 in OpenERP Addons: "account_payment: structured reference type is not reflected when importing from invoice"
  https://bugs.launchpad.net/openobject-addons/+bug/1105067

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1105067-account_payment_reference_type/+merge/144935

I've chosen to specifically not test for any reference type such as 'bba' etc but instead opted to detect when it is not 'Free' (which in the fields.select is value 'none') and in such cases mark the payment line reference as to be structured.
-- 
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1105067-account_payment_reference_type/+merge/144935
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1105067-account_payment_reference_type.

=== modified file 'account_payment/wizard/account_payment_order.py'
--- account_payment/wizard/account_payment_order.py	2012-12-06 14:56:32 +0000
+++ account_payment/wizard/account_payment_order.py	2013-01-25 13:29:25 +0000
@@ -88,6 +88,7 @@
                     'partner_id': line.partner_id and line.partner_id.id or False,
                     'communication': line.ref or '/',
                     'date': date_to_pay,
+                    'state': line.invoice and line.invoice.reference_type != 'none' and 'structured' or 'normal',
                     'currency': (line.invoice and line.invoice.currency_id.id) or line.journal_id.currency.id or line.journal_id.company_id.currency_id.id,
                 }, context=context)
         return {'type': 'ir.actions.act_window_close'}