openerp-community team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Approve

Hello Raphaël, 

LGTM is for "Looks Good To Me" ;) Thanks for the question cause it really makes me laugh this morning, I was quite hearing you shouting "C'est quoi cette merde" :) !

For the Merge, it's alright for me, just little remark for Benoit, on line 177 you should have split the line IMO. but well this is not a blocking point !

Have a nice day,

Regards,

Joël
-- 
https://code.launchpad.net/~akretion-team/openerp-product-attributes/product-attributes-port70-codesprint/+merge/147962
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.