openerp-community team mailing list archive

[Raphaël Valyi - http://www.akretion.com <rvalyi@xxxxxxxxx>]

Raphaël Valyi - http://www.akretion.com has proposed merging lp:~akretion-team/openerp-product-attributes/base_custom_attributes-inherited-domain into lp:openerp-product-attributes.

Requested reviews:
  Product Core Editors (product-core-editors)

For more details, see:
https://code.launchpad.net/~akretion-team/openerp-product-attributes/base_custom_attributes-inherited-domain/+merge/177243

As discussed on twitter with some CampToCamp member (hell I cannot remember who exactly), domain is already inherited from ir.fields parent object and should not be defined again
(domain usage is an advanced usage: when custom options point to OpenERP classes and should allow only a specific domain or in a product configurator prospective with dynamic domains).
-- 
https://code.launchpad.net/~akretion-team/openerp-product-attributes/base_custom_attributes-inherited-domain/+merge/177243
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.

=== modified file 'base_custom_attributes/custom_attributes.py'
--- base_custom_attributes/custom_attributes.py	2013-06-18 16:17:27 +0000
+++ base_custom_attributes/custom_attributes.py	2013-07-27 02:13:29 +0000
@@ -176,7 +176,6 @@
         'option_ids': fields.one2many('attribute.option', 'attribute_id', 'Attribute Options'),
         'create_date': fields.datetime('Created date', readonly=True),
         'relation_model_id': fields.many2one('ir.model', 'Model'),
-        'domain': fields.char('Domain', size=256),
         }
 
     def create(self, cr, uid, vals, context=None):