openerp-community team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Information

Thank you Maxime, for putting this up after the collective input was gathered on the pad!

Could you split off l.108 in a separate stanza about things to consider when committing an approved proposal to its target branch?

Also I would like to see l.109 make explicit that it concerns the proposed branch, so that it can not be understood as encouraging the merging party to link the target branch to the bug report at merge time.

l.148 Maybe "NO TEST at all will soon be a no go" should say "Having tests is very much encouraged" until the OCA decides otherwise.

l.138 does not really add anything to l.136. Saying 'Code review, no test' is just a more emphatic way of saying 'Code review', right?

@Guewen: I still think the 3 working days is not very meaningful in a world wide community, so I would prefer to go the other way and drop this terminology in favour of 5 calendar days.

Nothing in this proposal is factually wrong and probably subject to taste, so I'll set my review to 'Needs Information' rather than 'Needs fixing'
-- 
https://code.launchpad.net/~openerp-community/openobject-doc/7.0-community-review/+merge/186295
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-doc/7.0-community-review.