← Back to team overview

openerp-community team mailing list archive

Re: lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes

 

Review: Needs Fixing

Thanks Humberto.

Minor fixes:

l30,31: Can you use "from . import" ?
l79: Can you fix indentation ?
l121:  Can you use "from . import" ?
l155, datetime, as a standard Python library, should be imported before OpenERP-specific ones.
l161,162: Can you fix indentation ?

Can you add the translation file and remove the wizard and workflow directories ? I guess they will be used later with the new features.
-- 
https://code.launchpad.net/~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha/+merge/189956
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.


Follow ups

References