← Back to team overview

openerp-community team mailing list archive

Re: lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes

 

Review: Needs Fixing code review

Hi Joao,

In the on_change methods (l.124,135,144), I propose to add the "context=None" argument and propagate it to the calls (l.138,147). Thus, if someone want to use the context in a module extending yours, he will be able just be inheriting the views.

Apart that, LGTM
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies/+merge/185082
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.


References