openerp-community team mailing list archive

[Alexandre Fayolle <alexandre.fayolle@xxxxxxxxxxxxxx>]

I personnally won't block a MP for a couple of long lines in otherwise 
clean code.

OTOH a files such as account/account.py or account/account_invoice.py 
(not pointing fingers at anyone, just mentionning ones which have been 
bugging me since I started with OpenERP) could do with some gentle 
reformatting and I would probably the author of such a module to 
improve the situation a bit since it is always better to have such 
reformatting done before the merge...

Alexandre


On ven. 22 nov. 2013 09:53:30 CET, Nhomar Hernández wrote:
>
> 2013/11/22 Alexandre Fayolle <alexandre.fayolle@xxxxxxxxxxxxxx
> <mailto:alexandre.fayolle@xxxxxxxxxxxxxx>>
>
>     Wait until you age and have problems reading tiny weeny letters :-)
>
>     Yes my code editor wraps lines. The result is not developer
>     friendly, because the line breaking is not hand crafted and comes
>     all over the place.
>
>     247 long lines are unmanageable, as your eyes are unable to find
>     the beginning of the next line. There is a reason why newspaper
>     print in columns and not in page-wide lines. By your argument, it
>     would be easier for everyone since most article would only take up
>     1-5 lines.
>
>
> TOTALLY agreed with you alex.
>
> Just in my experience, when you must manage 5 consoles at same time,
> with vim and other "Server" tools it is better less long lines.
>
> I can live with 99 or 79 (we are using 99 internally) but 79 is fine.
>
> but honestly at the end of the day, it is subjective, sometimes a
> longest line should not stop a merge or can not be see it as "brake
> the rule" if it help in readability.
>
> Sometimes brake the line disturb readability too.... (but it is the
> exception)
>
> Regards.
>
>
> --
> --------------------
> Saludos Cordiales
>
> Nhomar G. Hernandez M.
> +58-414-4110269
> Skype: nhomar00
> Web-Blog: http://geronimo.com.ve <http://geronimo.com.ve/>
> Servicios IT: http://vauxoo.com <http://vauxoo.com/>
> Linux-Counter: 467724
> Correos:
> nhomar@xxxxxxxxxxxxxx <mailto:nhomar@xxxxxxxxxxxxxx>
> nhomar@xxxxxxxxxx <mailto:nhomar@xxxxxxxxxx>
> twitter @nhomar



--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com