openerp-community team mailing list archive

Thread
Date

Re: lp:~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field into lp:openerp-product-attributes

To: mp+190146@xxxxxxxxxxxxxxxxxx
From: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
Date: Mon, 25 Nov 2013 16:53:00 -0000
In-reply-to: <20131009143134.14983.80799.launchpad@ackee.canonical.com>
Reply-to: mp+190146@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

Thanks Guewen.

I suggest to copy/paste some or all of the explanation you give on the MP to a comment in the code.

Otherwise LGTM.

L
-- 
https://code.launchpad.net/~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field/+merge/190146
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.

Follow ups

Re: lp:~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field into lp:openerp-product-attributes
From: Guewen Baconnier @ Camptocamp, 2013-11-26

References

lp:~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field into lp:openerp-product-attributes
From: Guewen Baconnier @ Camptocamp, 2013-10-09