openerp-community team mailing list archive

Thread
Date

Re: lp:~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field into lp:openerp-product-attributes

To: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Tue, 26 Nov 2013 09:06:58 -0000
In-reply-to: <20131125165300.10207.40849.codereview@gac.canonical.com>
Reply-to: mp+190146@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Thanks Guewen.
> 
> I suggest to copy/paste some or all of the explanation you give on the MP to a
> comment in the code.
> 
> Otherwise LGTM.
> 
> L

Makes sense! I added some explanations.

Thanks for your review
-- 
https://code.launchpad.net/~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field/+merge/190146
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.

References

Re: lp:~openerp-community/openerp-product-attributes/7.0-product_custom_attributes-allow-to-bind-on-existing-field into lp:openerp-product-attributes
From: Leonardo Pistone @ camptocamp, 2013-11-25