← Back to team overview

openerp-community team mailing list archive

Re: [Merge] lp:~gdgellatly/openerp-product-attributes/partner-pricelist-7 into lp:openerp-product-attributes

 

I really wish people would understand I didn't change anything here.  I
tried really hard to change nothing except allow choosing a partner instead
of a pricelist in what was already existing functionality, but it seems
community merges are impossible.


On Tue, Feb 11, 2014 at 12:41 AM, Graeme Gellatly <gdgellatly@xxxxxxxxx>wrote:

> Sorry, I correct myself, it is not even a functional field just a dummy
> field.  It adds precisely nothing to product model,
>
>
> On Tue, Feb 11, 2014 at 12:38 AM, Graeme Gellatly <gdgellatly@xxxxxxxxx>wrote:
>
>> it's just a functional field no different to pricelist which is in core
>> of product.  How is it different to core, I fail to see any distinction at
>> all.
>>
>>
>> On Mon, Feb 10, 2014 at 10:50 PM, Markus Schneider <
>> markus.schneider@xxxxxxxxxx> wrote:
>>
>>> Hi Graeme,
>>>
>>> thank you for your replay. My suggestion was only that we think about
>>> this topic and what was our solution.
>>>
>>> You are right that we can only see information about a product one by
>>> one. So it can be helpfull to have a full list. Okay you can export a
>>> complete pricelist as pdf. So the goal is to have a interactive list.
>>>
>>> Here is the point thinking about this solution i don't like. I try to
>>> explain.
>>>
>>> Adding partner_id to the product is bad, becouse it adds context to the
>>> product. In my understanding of good programming a basic modle like
>>> product.product should be context free. So i suggest instead of having a
>>> extension of product.product it would be better to add a reporting model
>>> (which inherits from product.product) and than you can add the context
>>> there like partner.
>>> This has also a second benefied. As you see in practice customer
>>> specific price changes on time. And you will have soon the problem that you
>>> want to know, what was the price last year, or what will be the price next
>>> year. That it is easyer to extend a reporting model instead adding this
>>> context to the product.product model.
>>> --
>>>
>>> https://code.launchpad.net/~gdgellatly/openerp-product-attributes/partner-pricelist-7/+merge/202985
>>> You are the owner of
>>> lp:~gdgellatly/openerp-product-attributes/partner-pricelist-7.
>>>
>>
>>
>

-- 
https://code.launchpad.net/~gdgellatly/openerp-product-attributes/partner-pricelist-7/+merge/202985
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.


References