openerp-community team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss into lp:~openerp-community/server-env-tools/6.1-mass_editing

To: mp+201321@xxxxxxxxxxxxxxxxxx
From: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 18 Mar 2014 13:27:23 -0000
In-reply-to: <20140112195425.26099.84092.launchpad@ackee.canonical.com>
Reply-to: mp+201321@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

OK, sorry about the misunderstanding.
Nevertheless, I would prefer to see some assertions, gets and tries as this function looks likely to throw an IndexError.
But I see you've take them into account (removal of redundant checks, values checking, etc)
-- 
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

References

[Merge] lp:~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss into lp:~openerp-community/server-env-tools/6.1-mass_editing
From: Stefan Rijnhart (Therp), 2014-01-12