openerp-community team mailing list archive

[Sandy Carter <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Hi David,

I thought about adding pep8 checking.
Though it is possible, the design of runbot does not exactly make this easy, and since we already have travis doing this, I have not made it a priority.
In the official runbot code, there is some commented out coverage code, so they have obviously planned to use it.

The rundown of runbot's limitations:
runbot will run functions with the name `job_##_test_name`, currently it only has:
* job_10_test_base
* job_20_test_all
* job_30_run

Adding pep8 would be something like adding `job_05_test_pep8` but there are two problems:
* Firsly, job_10_test_base is the job which will do the setup of your work tree (git checkout, etc).
  Optimally, a better design would have had that be in a separate job on its own like `job_00_checkout`
  As it is, you can't run pep8 before the actual Odoo tests.
* Secondly, runbot error checking is really just an Odoo log parser, it is designed to find Odoo Errors, 
  to have it look for and display the pep8 errors in the log view web page would require some significant 
  refactoring of the code and considering there has been very little activity for my few relatively minor
  fixes, I hold no hope to have that integrated any time soon.

--
Sandy

----- Mail original -----
De: "David Arnold - El Alemán" <david@xxxxxxxxxxx>
À: "Joël Grand-Guillaume" <joel.grandguillaume@xxxxxxxxxxxxxx>
Cc: "Sandy Carter" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>, "openerp-community" <openerp-community@xxxxxxxxxxxxxxxxxxx>
Envoyé: Lundi 23 Juin 2014 16:06:10
Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github



@ Sandy, we already love your travis-pep8 combo and we are actively using it (bacause style matters :) ). However of Runbot killerfeature of a running DB, I wanted to ask, if you probably could include pep8 on the diff on the runbot. AFAIK you proposed something on odoo, and I don't recall if they got your idea (about the diffs) properly. 


However, the community could be free to choose including a pep8 style check on every future diff. 


I'm really looking forward to get all this state of the art stuff working upon the github transition. :D 



2014-06-23 13:43 GMT-05:00 Joël Grand-Guillaume < joel.grandguillaume@xxxxxxxxxxxxxx > : 







Hi Sandy, 


This is very interesting indeed ! What I can suggest is: 

* You're part of the team that maintain the maintainers tools. I suggest that you use this repository to share your work with a pull request : https://github.com/OCA/maintainers-tools (the OCA repo to help the community maintainers team) 

* For the suggestion about forking odoo-extra, I will try to make the pull request reviewed instead of forking them. If in the hurry, fork it for now. 

* Concerning this work of building a community runbot, I added you to our odoo instance as a member of the community maintainer project. You now have a task assigned (if ok for you, so I let you take this responsibility). If you agree, please feel free to take note in the tasks, adding description and changing his status. 

Thanks a million for this ! 

Regards, 

Joël 













On Mon, Jun 23, 2014 at 6:21 PM, Sandy Carter < sandy.carter@xxxxxxxxxxxxxxxxxxxx > wrote: 


On the topic of Runbot. 

Here at SLF, I have managed to deploy it for our own uses. 
I am sure many of you have read it already but for those who didn't here's the result of my experiment[1]. 

Since then, I have made an addon to runbot which gives more customisability to what runbot runs, mainly to work with our internal installation script which uses the buildout recipe. 
The addon, non-intrusively adds the ability to run pre-run scripts, custom server locations and additional parametters to runbot jobs. 
I also plan on making another module for integration with gitlab instead of github, again for internal projects. 

The problem I am facing is that I currently have 4 open Pull Requests[2] for odoo-extra (where runbot code is hosted) which are quite vital to testing OCA modules and it doesn't look like they are getting any attention they deserve. 
Adding to that, I would love to contribute my runbot_custom module, but there is currently nowhere to host it. The latter problem can be easily resolved by pointing out a repo to put it in or the creation of a runbot-addons repo. 

Should we fork odoo-extra and add modules to the fork, or should we wait until the fixes get integrated? 

[1] http://bwrsandman.wordpress.com/2014/06/16/using-odoos-runbot-to-test-oca-addons/ 
[2] https://github.com/odoo/odoo-extra/pulls/bwrsandman 
-- 
Sandy 

----- Mail original ----- 
De: "Moises Lopez" < moylop260@xxxxxxxxxx > 
À: "Laurent Mignon" < laurent.mignon@xxxxxxxxx > 
Cc: "openerp-community" < openerp-community@xxxxxxxxxxxxxxxxxxx > 
Envoyé: Lundi 23 Juin 2014 09:32:03 
Objet: Re: [Openerp-community] OCA: transition from Launchpad to Github 






Hello, 
+1 with full migration to github... with scripts. 

In github you will have new runbot available with PR for test it. 
In github you will have just one tool of version control. 
And you can make some script to migrate base branches and merge proposal branches. 

Note, in old runbot refactory by vauxoo we check the MP here: 
http://bazaar.launchpad.net/~vauxoo/openerp-tools/runbot7_vauxoo_stable/view/head:/openerp-runbot/openerprunbot/core.py#L715 

We can use same concept to migrate MP to github. 

*Bugs and blueprint to issue. 

Translation Olivier told us: 
"""" 
" 7. Translations [Planned Q3 2014] 
The v8 release is too soon to allow setting up a new translation process on top 
of GitHub, especially as there is almost nothing built-in. 

Translators will still continue to work on LP at least until v8 is released. We 
will set up a replay system to update the translation templates 
`addons/i18n/*.pot` on LP with the latest terms from master/v8.0 in GitHub. And 
in the other direction, we will replay the PO updates on `addons/i18n/*.po` 
from LP to GitHub. 

After the release of v8 we will set up a new translation process, probably 
built on top of Transifex." 
""" 

*TODO script. 

We can help with dev of this script in python if you like it. 
El jun 23, 2014 8:07 AM, "Mignon, Laurent" < laurent.mignon@xxxxxxxxx > escribió: 



HI, 


I am also in favor of an earlier migration to github. We are a community, and as such I would like to avoid introducing processes and tools that would be specific OCA. The greater part of us probably have enough experience to continue with both systems and even if IMHO it will introduce a lot of unnecessary complexity. However, if we want to remain / become an attractive and open community that can only be done if we use the tools of the community based on non-specific process to OCA. 



How to explain to a new contributor that he must know launchpad to contribute to OCA modules in 7.0 and Github for 8.0? 

Are our employers willing to bear the cost of training launchpad and github? Not to mention the specific processes introduced by OCA to support this duality ... 



If OCA remains on launchpad while Odoo is on github, I feel we may see a large number of OCA modules migrated to Github outside the control of OCA because people simply find it easier to have everything on Github and will want to avoid further invest in launchpad. 



One last point, I am one of those who blames Odoo not always follow community practices whether in terms of formatting code (pep8) or in the packaging of addons (python eggs). At the transition from launchpad to github, I'd avoid that OCA introduce its own processes and tools to support both systems simultaneously. 



I think if we do not choose now to migrate everything to Github, it will never be possible. 



My 2 cents, 


lmi 





On Mon, Jun 23, 2014 at 1:43 PM, Info SHS-AV < info@xxxxxxxxxx > wrote: 





Il 23/06/2014 12:58, Lorenzo Battistini ha scritto: 




On 06/23/2014 11:16 AM, Joël Grand-Guillaume wrote: 








Hi, 


First thank you for your feedback. About the LP -> Github migration. The main arguments in favor of keeping v 6.1 and 7.0 on LP and mirror on Github is that we do have lot's of reviews in progress. It'll be difficult to maintain reviews on LP if the master is Github. 

+1 



We could follow the same approach as OpenERP SA: 
https://github.com/odoo/odoo/wiki/GitHub-Transition 



About merge proposals , the page says: 
Whenever such a MP is merged it will be forwarded to GitHub using this script. 
But that link doesn't take to the script. 

Does anybody know such a script? 

-- 
Lorenzo Battistini 


_______________________________________________ 
Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp 

-- 


Antonio M. Vigliotti 
(Presidente & C hief Technical Officer ) 

SHS-AV s.r.l. (impresa innovativa) 
zero incombenze ® 


Via Domodossola, 64 - 10145 TORINO - ITALY 


Tel. (+39) 011.0566929 (2) 


www.shs-av.com 

PEC shs-av@xxxxxxxxxxxx 


_______________________________________________ 
Mailing list: https://launchpad.net/~openerp-community 
Post to : openerp-community@xxxxxxxxxxxxxxxxxxx 
Unsubscribe : https://launchpad.net/~openerp-community 
More help : https://help.launchpad.net/ListHelp 





-- 

Laurent Mignon 
Senior Software Engineer 

Tel : +352 20 21 10 20 32 
Fax : +352 20 21 10 21 
Gsm : +352 691 506 009 
Email: laurent.mignon@xxxxxxxxx 

Acsone SA, Succursale de Luxembourg 
22, Zone industrielle 
L-8287 Kehlen, Luxembourg 
www.acsone.eu 




_______________________________________________ 
Mailing list: https://launchpad.net/~openerp-community 
Post to : openerp-community@xxxxxxxxxxxxxxxxxxx 
Unsubscribe : https://launchpad.net/~openerp-community 
More help : https://help.launchpad.net/ListHelp 


_______________________________________________ 
Mailing list: https://launchpad.net/~openerp-community 
Post to : openerp-community@xxxxxxxxxxxxxxxxxxx 
Unsubscribe : https://launchpad.net/~openerp-community 
More help : https://help.launchpad.net/ListHelp 

_______________________________________________ 
Mailing list: https://launchpad.net/~openerp-community 
Post to : openerp-community@xxxxxxxxxxxxxxxxxxx 
Unsubscribe : https://launchpad.net/~openerp-community 
More help : https://help.launchpad.net/ListHelp 




-- 





















camp to camp 
INNOVATIVE SOLUTIONS 
BY OPEN SOURCE EXPERTS 


Joël Grand-Guillaume Division Manager 
Business Solutions 




+41 21 61 9 10 28 
www.camptocamp.com 




_______________________________________________ 
Mailing list: https://launchpad.net/~openerp-community 
Post to : openerp-community@xxxxxxxxxxxxxxxxxxx 
Unsubscribe : https://launchpad.net/~openerp-community 
More help : https://help.launchpad.net/ListHelp