openerp-dev-web team mailing list archive

["noz \(Open ERP\)" <noz@xxxxxxxxxxx>]

> Hi,
> There is some things I would like you to modify related to the getWeek()
> method:
> 
> - First try remove the argument, it's not really useful and adds confusion. If
> we want to implement the ISO 8601 we don't want to give the guy that will
> reuse this method some choice about whether we should consider monday of
> sunday as the first day of the week, if the ISO tells it's sunday so it's
> sunday.
> - Please document the method, at least say that you implement ISO 8601. Yeah,
> I know it was not written anywhere before, that's a good opportunity to do it
> :)
> 
> Except that it seems correct.

Agree with Nicolas, 
and there should be some spaces between blocks like, in getWeek(), variables declaration should be in one block, if-else condition should be in another block after one line space etc..
Spaces should be there after operators.

so that it should be readable.
After these changes you can merge it.
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/improved_calendar/+merge/44455
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/improved_calendar.