openerp-dev-web team mailing list archive

[xrg <xrg@xxxxxxxxx>]

On Monday 14 March 2011, you wrote:
> Kirti Savalia(OpenERP) has proposed merging
> lp:~openerp-dev/openobject-addons/trunk-bug-733143-ksa into
> lp:openobject-addons.
> 
> Requested reviews:
>   OpenERP Core Team (openerp)


/without/ reading anything outside your patch, I can spot the following 
questions about it:

you have: pricelist_id = ... .get(pricelist, False)
and then: version = ... .browse(.., pricelist_id)

What happens when pricelist_id == False ?

Then, a few lines below, after this browse(), you do check again, too late:
  if res_dict.get('item_id',False) and \
                    res_dict['item_id'].get(pricelist,False):
what's the point?




-- 
Say NO to spam and viruses. Stop using Microsoft Windows!

https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-733143-ksa/+merge/53193
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-733143-ksa.