openerp-dev-web team mailing list archive

["Naresh\(OpenERP\)" <nch@xxxxxxxxxxx>]

Naresh(OpenERP) has proposed merging lp:~openerp-dev/openobject-client/trunk-bug-756343-nch into lp:openobject-client.

Requested reviews:
  OpenERP sa GTK client R&D (openerp-dev-gtk)
Related bugs:
  Bug #756343 in OpenERP GTK Client: "O2M: D&D should not call write if the model is not saved."
  https://bugs.launchpad.net/openobject-client/+bug/756343

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-client/trunk-bug-756343-nch/+merge/57114

contains the fix for the bug and improvement in naming convention.

Thanks,
nch(OpenERP)
-- 
https://code.launchpad.net/~openerp-dev/openobject-client/trunk-bug-756343-nch/+merge/57114
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client/trunk-bug-756343-nch.

=== modified file 'bin/widget/model/group.py'
--- bin/widget/model/group.py	2010-12-16 07:01:07 +0000
+++ bin/widget/model/group.py	2011-04-11 07:11:29 +0000
@@ -128,8 +128,8 @@
     def set_sequence(self, get_id, rec_id, field='sequence'):
         seq_ids = []
         index = 0
-        for module in self.models:
-             seq_ids += [module[field].get(module)]
+        for model in self.models:
+             seq_ids += [model[field].get(model)]
              index = index +1
 
         set_list = list(set(seq_ids))
@@ -143,9 +143,10 @@
             final_list = set_list + mod_list
 
             index = 0
-            for module in self.models:
-                module[field].set(module, final_list[index], modified=True)
-                module.save()
+            for model in self.models:
+                model[field].set(model, final_list[index], modified=True)
+                if model.id:
+                    model.save()
                 index = index +1
         else:
             seq_id = []
@@ -156,7 +157,8 @@
                 index = 0
                 for x in range(get_id, rec_id):
                     self.models[x][field].set(self.models[x], sort_seq[index], modified=True)
-                    self.models[x].save()
+                    if self.models[x].id:
+                        self.models[x].save()
                     index = index +1
             else:
                 for x in range(rec_id,get_id+1):
@@ -165,7 +167,8 @@
                 index = 0
                 for x in range(rec_id,get_id+1):
                     self.models[x][field].set(self.models[x], sort_seq[index], modified=True)
-                    self.models[x].save()
+                    if self.models[x].id:
+                        self.models[x].save()
                     index = index +1