openerp-dev-web team mailing list archive

["Anup\(OpenERP\)" <ach@xxxxxxxxxxx>]

Hello Jay,

   Thanks a lot for a detailed investigation. I have fixed many of the issues mentioned by you like indentations and naming conventions, child_of, shorthand operator,notifications etc.

4.Currently order = 'parent_left' is giving the same result as id. But IMHO it's better to keep id rather than parent_left.

5. You are right we don't need that line. It saves many read calls and we don't even need that variable.

11. Well The wizard should be used with a single inventory only. You can not use it with multiple inventories. I have kept a notification if more than one inventory is selected. So it solves the issue.

We even don't need the lines 38-42. When will it be the case when ids will not be there?

Please share your views.

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-bug_725908-ach/+merge/56554
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-bug_725908-ach.