openerp-dev-web team mailing list archive

Thread
Date

Re: lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db

To: "Kirti Savalia\(OpenERP\)" <ksa@xxxxxxxxxxx>
From: "Rucha \(Open ERP\)" <rpa@xxxxxxxxxxx>
Date: Thu, 28 Apr 2011 13:19:24 -0000
In-reply-to: <20110428130824.32558.25620.launchpad@loganberry.canonical.com>
Reply-to: mp+59368@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
1) Improve code:

On a fresh installation of DB i got following error:

[2011-04-28 18:45:49,596][readd] ERROR:web-services:[52]:     return super(orm_temporal, self).read(cr, uid, data, fields=original_fields, context=context, load=load)
[2011-04-28 18:45:49,596][readd] ERROR:web-services:[53]: UnboundLocalError: local variable 'original_fields' referenced before assignment

2) 2 returns in function search at one indentation level? last will never be reached :-D
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/59368
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db.

References

lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
From: Kirti Savalia(OpenERP), 2011-04-28