← Back to team overview

openerp-dev-web team mailing list archive

Re: lp:~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi into lp:~openerp-dev/openobject-addons/trunk-payroll

 

Review: Needs Fixing
few points to correct:

1) [2011-04-28 15:14:35,238][payroll_avr_28] WARNING:init:object hr.payslip.groups (hr.payslip.groups) has no access rules!

2) when selecting a category, i should search for employees in that category but also for employees in a category child of this category

3) wwhen computing the payslip of employees, you must call the onchange_employee_id method otherwise the input lines for him won't be created and when openerp is trying to compute them it's raising error like "invalid quantity for meal voucher rule" (because there isn't an input line with code = WORK100)

4) add the m2o on the payslip form view too, in the tab "other information"

thanks
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll.


References